-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6813/
-----------------------------------------------------------
Review request for shindig.
Description
-------
Some feature XMLs do not properly leverage the all tag in order to avoid
loading javascript files multiple times when the Feature registry is populated.
The ones that we can fix are listed below.
The Feature Registry reads a javascript file multiple times if the feature.xml
includes it multiple times, such as in container and gadget sections. The
following files are being read multiple times according to the procmon IO Trace
features/core.json
features/exportjs
features/gadgets.json.ext
features/shindig.uri.ext
Two of the features
features/osapi/
features-extras/org.openajax.hub-2.0.5
have situations where specific files are needed by the gadget and / or the
container so they cannot leverage the all tag
This addresses bug SHINDIG-1861.
https://issues.apache.org/jira/browse/SHINDIG-1861
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.json/feature.xml
1378124
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/exportjs/feature.xml
1378124
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/gadgets.json.ext/feature.xml
1378124
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.uri.ext/feature.xml
1378124
Diff: https://reviews.apache.org/r/6813/diff/
Testing
-------
Ran unit tests
Thanks,
Ryan Baxter
