----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6841/#review10947 -----------------------------------------------------------
Ship it! Ship It! - Henry Saputra On Aug. 29, 2012, 10:09 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6841/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2012, 10:09 p.m.) > > > Review request for shindig. > > > Description > ------- > > I would like to enable Apache RAT as part of the Shindig maven build process. > This would allow issues normally found only during the release process to be > found during the CI builds of Shindig and during local builds. This should > help to make the release process better for betas. > > The rat:check goal will now run as part of the "reporting" profile. The > execution phase and goal were copied from the "release" profile. > > I'd especially like inputs on the excludes. I added the ones that I found in > my Eclipse environment and would welcome more if deemed necessary. > > > This addresses bug SHINDIG-1865. > https://issues.apache.org/jira/browse/SHINDIG-1865 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1378400 > > Diff: https://reviews.apache.org/r/6841/diff/ > > > Testing > ------- > > Ryan Baxter had identified two RAT issues on the dev list. I built in my > local Eclipse environment at a revision of Shindig that did not have his > fixes. My local build identified those failures, I updated SVN, and on a > subsequent re-run everything passed. > > > Thanks, > > Stanton Sievers > >
