> On Sept. 4, 2012, 6:41 p.m., Henry Saputra wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/SecurityTokenCodec.java, > > line 65 > > <https://reviews.apache.org/r/6906/diff/3/?file=149507#file149507line65> > > > > Might as well just remove this interface because other than tests, all > > the current usage should pass a container.
I decided to deprecate it in the latest patch. I'm always concerned about breaking interfaces and would rather leave it for now and remove it in 3.0. Marking it deprecated now gets us on the path to removing it later. - Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6906/#review11027 ----------------------------------------------------------- On Sept. 4, 2012, 6:46 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6906/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2012, 6:46 p.m.) > > > Review request for shindig and Dan Dumont. > > > Description > ------- > > Today the gadget security token TTL is not configurable. It is hard-coded to > one hour. This patch makes the token ttl configurable via the container.js. > > > This addresses bug SHINDIG-1859. > https://issues.apache.org/jira/browse/SHINDIG-1859 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AbstractSecurityToken.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BasicSecurityTokenCodec.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenCodec.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/SecurityTokenCodec.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BasicSecurityTokenCodecTest.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/UrlParameterAuthenticationHandlerTest.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/testing/FakeGadgetToken.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java > 1380743 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java > 1380743 > > Diff: https://reviews.apache.org/r/6906/diff/ > > > Testing > ------- > > Updated existing unit tests. Configured TTL to be 5 minutes and verified > that the sample common container page was properly refreshing the tokens. > > > Thanks, > > Stanton Sievers > >
