----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7857/#review13091 -----------------------------------------------------------
Ship it! LGTM. If testing with a functional settimeout is something you want to do, I had implemented it here in the attached patch: https://issues.apache.org/jira/browse/SHINDIG-1864 This patch hasn't made it in. - Dan Dumont On Nov. 4, 2012, 3:40 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7857/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2012, 3:40 p.m.) > > > Review request for shindig, Dan Dumont and Matt Franklin. > > > Description > ------- > > From the Jira: > When using the "preloadMetadatas" and "preloadTokens" optional config when > constructing an osapi.container.Container, the token refresh schedule will be > based on the TTL of whatever is in "preloadMetadatas" and not "preloadTokens". > > > This addresses bug SHINDIG-1880. > https://issues.apache.org/jira/browse/SHINDIG-1880 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js > 1405426 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/container_test.js > 1405426 > > Diff: https://reviews.apache.org/r/7857/diff/ > > > Testing > ------- > > Wrote some new JSUnits to cover this use case. These are included in the > patch. Some of the "window.setTimeout" code in the JSUnit is odd, but it's > the only way I could get it to not puke with reference errors saying that > "setTimeout" is undefined when it is called in > osapi.container.Container.scheduleRefreshTokens_. > > > Thanks, > > Stanton Sievers > >
