----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8247/#review14913 -----------------------------------------------------------
Ship it! Committed revision 1425942. Please close the review. - Ryan Baxter On Dec. 18, 2012, 7:28 a.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8247/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2012, 7:28 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > Default container.js has such setting for open social feature: > "opensocial" : { > // Path to fetch opensocial data from > // Must be on the same domain as the gadget rendering server > "path" : "http://%host%${CONTEXT_ROOT}/rpc";, > // Path to issue invalidate calls > "invalidatePath" : "http://%host%${CONTEXT_ROOT}/rpc";, > > Problem with these setting is that if consumer deploy Shindig with HTTPS, > they need to manually change the http here to https. Proposal is to leave the > scheme part of the setting empty, so the request will be sent in relative > scheme by default. > > > This addresses bug SHINDIG-1884. > https://issues.apache.org/jira/browse/SHINDIG-1884 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1397011 > > Diff: https://reviews.apache.org/r/8247/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Marshall Shi > >
