> On Nov. 21, 2012, 2:06 p.m., Ryan Baxter wrote: > > I am not sure I understand the need to override the properties module, > > which properties are you changing? > > > > Also I think the container code is overly complex, it could be a lot > > simpler than it is now. In my opinion simpler is better because all we are > > really trying to do is get them started and most people will remove almost > > all the code in the container page and customize it.
In the example I didn't change any properties. However, this was one of the first tasks I did when using shindig. And it took some time to find out how. With the overridden PropertiesModule it's just a matter of editing the properties file. Simplifying the container code further would be great but I'm afraid I don't have the time to do this. Actually I was happy that I could make it as short as it is in the patch. > On Nov. 21, 2012, 2:06 p.m., Ryan Baxter wrote: > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/java/org/apache/shindig/common/MyPropertiesModule.java, > > line 1 > > <https://reviews.apache.org/r/8160/diff/1/?file=222540#file222540line1> > > > > You should add the Apache license header to this file. Also you want > > to add it to any other files that are already checked in as well. I am not > > sure if we missed that in the last patch. Feel free to add the apache license header. I don't have time for this, sorry. > On Nov. 21, 2012, 2:06 p.m., Ryan Baxter wrote: > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/webapp/index.html, > > line 29 > > <https://reviews.apache.org/r/8160/diff/1/?file=222543#file222543line29> > > > > Why use the 1.7.2 CSS file but use the 1.4.2 version of JQuery? Probably a copy/paste error from various sources. Feel free to change it. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8160/#review13666 ----------------------------------------------------------- On Nov. 21, 2012, 2:23 p.m., Martin Höller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8160/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2012, 2:23 p.m.) > > > Review request for shindig, Henry Saputra and Ryan Baxter. > > > Description > ------- > > Update sample-maven-archetype to use common container (as suggested by Ryan > in SHINDIG-1482). > There is a JIRA issue for this: SHINDIG-1882 > > > This addresses bug SHINDIG-1882. > https://issues.apache.org/jira/browse/SHINDIG-1882 > > > Diffs > ----- > > > /trunk/java/sample-maven-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml > 1411344 > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/java/org/apache/shindig/common/MyPropertiesModule.java > PRE-CREATION > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/resources/shindig.properties > 1411344 > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/webapp/WEB-INF/web.xml > 1411344 > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/webapp/index.html > 1411344 > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/webapp/my-container.js > PRE-CREATION > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/webapp/myFirstGadget.xml > 1411344 > > /trunk/java/sample-maven-archetype/src/main/resources/archetype-resources/src/main/webresources/css/gadgets.css > 1411344 > > Diff: https://reviews.apache.org/r/8160/diff/ > > > Testing > ------- > > > Thanks, > > Martin Höller > >
