> On Jan. 7, 2013, 11:07 p.m., Henry Saputra wrote: > > +1 > > Henry Saputra wrote: > Actually could you add test in the service_test.js to cover this?
I had a quick try, but I'm really not that settled with JavaScript, JSUnit and the Shindig test setup. Eventually someone with more insight could contribute such a test. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8870/#review15126 ----------------------------------------------------------- On Jan. 7, 2013, 9:20 p.m., Martin Höller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8870/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2013, 9:20 p.m.) > > > Review request for shindig. > > > Description > ------- > > It seems the moduleID is not handled correctly in getGadgetToken(). > > I'm totally unsure, if this patch is complete but at least the local > variables "mid" and "url" are set to reasonable values with the patch. > > > This addresses bug SHINDIG-1891. > https://issues.apache.org/jira/browse/SHINDIG-1891 > > > Diffs > ----- > > /trunk/features/src/main/javascript/features/container/service.js 1416935 > > Diff: https://reviews.apache.org/r/8870/diff/ > > > Testing > ------- > > > Thanks, > > Martin Höller > >
