----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9096/ -----------------------------------------------------------
(Updated Jan. 24, 2013, 2:38 p.m.) Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson. Description ------- moduleID is defined as int and long respectively. Propose to unify them to long. This addresses bug SHINDIG-1897. https://issues.apache.org/jira/browse/SHINDIG-1897 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetContext.java 1406188 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1432956 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpGadgetContext.java 1406188 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsonRpcGadgetContext.java 1406188 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/variables/ModuleSubstituter.java 1406188 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/variables/ModuleSubstituterTest.java 1406188 Diff: https://reviews.apache.org/r/9096/diff/ Testing ------- Thanks, Marshall Shi