----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8952/#review15798 -----------------------------------------------------------
Ship it! Committed r1439978. Please close this review. - Dan Dumont On Jan. 20, 2013, 8:44 a.m., Marshall Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8952/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2013, 8:44 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Rich Thompson. > > > Description > ------- > > In EhCacheCacheProvider.java, it is creating a new CacheManager instance. > Prefer to use static create() method of CacheManager class to return a > singleton. > > > This addresses bug SHINDIG-1895. > https://issues.apache.org/jira/browse/SHINDIG-1895 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java > 1355349 > > Diff: https://reviews.apache.org/r/8952/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Marshall Shi > >
