-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9513/
-----------------------------------------------------------
(Updated Feb. 22, 2013, 1:19 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich
Thompson.
Description
-------
We've encountered problems that a proxy sitting in front of a Shindig server is
reading the cache control to determine whether or not to cache the content in
the proxy. It is problematic because the cache control max age defaults to 0 in
case of 304 response code in JsServlet.
We expect the cache control indicate that the response should be cached in
browser indefinitely.
The proposed fix is to set -1 as cacheTtl in the JsResponseBuilder and pass
that cacheTtl value back into the JsServlet response header.
This addresses bug SHINDIG-1904.
https://issues.apache.org/jira/browse/SHINDIG-1904
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/IfModifiedSinceProcessor.java
1406188
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/JsServlet.java
1435567
Diff: https://reviews.apache.org/r/9513/diff/
Testing
-------
Done
Thanks,
Marshall Shi
