----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9763/ -----------------------------------------------------------
(Updated March 7, 2013, 1:31 a.m.) Review request for shindig and Dan Dumont. Changes ------- Adding a JIRA. Description ------- I'd like to make the location of EhCache's disk stores easily configurable via the web.xml of an app, instead of having to inject one's own EhCacheCacheProvider. This addresses bug SHINDIG-1912. https://issues.apache.org/jira/browse/SHINDIG-1912 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java 1453022 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml 1453022 Diff: https://reviews.apache.org/r/9763/diff/ Testing ------- I set "ehcache.disk.store.dir" to "C:\tmp\.ehcache" in my web.xml and verified that EhCache started creating disk stores in that directory. I also verified that if I did not set "ehcache.disk.store.dir" then the disk stores were created in my system's temp directory, as defined by "java.io.tmpdir". Thanks, Stanton Sievers