-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12881/
-----------------------------------------------------------
Review request for shindig.
Bugs: SHINDIG-1922
https://issues.apache.org/jira/browse/SHINDIG-1922
Repository: shindig
Description
-------
In webkit browsers the onload handler gets called twice, which ends up
removing the iframe from the DOM. After looking at there appears to
be a few problems with the pubsub code and the onload handlers added
to the iframe. We add it in the iframe attributes and then add it to
the iframe again later on, which seems unneccessary. I think the root
cause of the onload listener being called twice has to do with onload
listener being added in the innerHTML string [1]. I will try to get
the change fix checked in over the next few days.
[1]
http://stackoverflow.com/questions/10781880/why-iframe-that-dynamic-created-trigger-onload-event-twice
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site_holder.js
1505501
Diff: https://reviews.apache.org/r/12881/diff/
Testing
-------
Existing unit tests pass
Thanks,
Ryan Baxter
