----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13613/#review25327 -----------------------------------------------------------
Ship it! Ship It! - Stanton Sievers On Aug. 19, 2013, 11:36 p.m., Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13613/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 11:36 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1923 > https://issues.apache.org/jira/browse/SHINDIG-1923 > > > Repository: shindig > > > Description > ------- > > I recently upgraded from 3.0.0-beta4 to 2.5.0-beta6, and found that the > MetadataResponse had changed from getIframeUrl to getIframeUrls > (Map<String,String>). However when I try accessing the value in this map I am > getting a ClassCastException. > > When looking in the code I noticed, > > https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java > > > the MetadataResponse inner class has a method getIframeUrls() with return > type Map<String,String>. > > However in: > > https://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java > > > the method getMetadata() shows the urls are defined as type Map<String,Uri>. > > As the MetadataResponse API has been changed anyway, could it not just be > changed to Map<String,Uri>? Or alternatively transform the map inside the > GadgetsHandlerService? > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java > 1513708 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java > 1513708 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java > 1513708 > > Diff: https://reviews.apache.org/r/13613/diff/ > > > Testing > ------- > > Updated unit tests > > > Thanks, > > Ryan Baxter > >
