----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13802/#review25552 -----------------------------------------------------------
Ship it! Could you please create a JIRA and add it to the Bugs section of the review? - Ryan Baxter On Aug. 26, 2013, 5:18 a.m., Zhi Hong Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13802/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2013, 5:18 a.m.) > > > Review request for shindig, Dan Dumont, Ryan Baxter, Rich Thompson, and > Stanton Sievers. > > > Repository: shindig > > > Description > ------- > > Bug fix for last review (configurable to support different SHA algorithm) > https://reviews.apache.org/r/11299 > > and add more junit tests. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/crypto/BasicBlobCrypter.java > 1517419 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenTest.java > 1517419 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/crypto/CryptoTest.java > 1517419 > > Diff: https://reviews.apache.org/r/13802/diff/ > > > Testing > ------- > > done > > > Thanks, > > Zhi Hong Yang > >
