-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13923/
-----------------------------------------------------------
(Updated Sept. 4, 2013, 11:49 p.m.)
Review request for shindig.
Changes
-------
Added a unit test that reproduces the issue. I decided to add Powermock as a
test-scoped dependency to help get at the CacheManager. I figure we can make
use of it in other unit tests moving forward as well.
Bugs: SHINDIG-1931
https://issues.apache.org/jira/browse/SHINDIG-1931
Repository: shindig
Description
-------
Reported on the dev list[1]. The issue is that the
CacheManager.create(Configuration) APIs will always use the same singleton,
regardless of whether the provided Configuration defines a cache manager of a
different name then the existing singleton. We should use the
CacheManager.newInstance(Configuration) APIs, as this will use a singleton per
cache manager name. This will keep us from stomping on other cache managers
that exist in the environment.
[1]
http://markmail.org/message/4adopzvvi3ltv7yq?q=Shindig+list:org.apache.shindig.dev+order:date-backward&page=1
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProvider.java
1519267
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/cache/ehcache/EhCacheCacheProviderTest.java
1519267
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/resources/testEhCacheConfig.xml
PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1519267
Diff: https://reviews.apache.org/r/13923/diff/
Testing
-------
Unit tests continue to pass. Shindig starts and samples load in the sample
container.
Thanks,
Stanton Sievers
