----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15040/#review28031 -----------------------------------------------------------
Ship it! Committed revision 1538053. I fixed the whitespace and also added the license header to the package-info.java file. - Ryan Baxter On Oct. 29, 2013, 6:37 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15040/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2013, 6:37 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1943 > https://issues.apache.org/jira/browse/SHINDIG-1943 > > > Repository: shindig > > > Description > ------- > > Reverse the condition when validating the request callback URI to match the > OAuth spec. > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/package-info.java > PRE-CREATION > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/validators/AuthCodeGrantValidator.java > 1536829 > > Diff: https://reviews.apache.org/r/15040/diff/ > > > Testing > ------- > > Local implementation of an oauth commandline client and independent web > application client can authenticate/authorize properly. > > > Thanks, > > Andreas Kohn > >
