----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15417/#review28647 -----------------------------------------------------------
trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2AuthenticationHandler.java <https://reviews.apache.org/r/15417/#comment55555> You've introduced some new functionality by allowing the token to be null. Is there a use case for this? If you want to bypass the request, I would rather see the getSecurityTokenFromRequest method get overridden instead of allowing this new method to affect how the AuthenticationHandler flow works. trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2AuthenticationHandler.java <https://reviews.apache.org/r/15417/#comment55556> What is the use case for throwing this exception? - Stanton Sievers On Nov. 11, 2013, 11:32 a.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15417/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2013, 11:32 a.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1950 > https://issues.apache.org/jira/browse/SHINDIG-1950 > > > Repository: shindig > > > Description > ------- > > Factor out creation of the actual SecurityToken in > OAuth2AuthenticationHandler into a separate method that can be overridden in > a child class. > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2AuthenticationHandler.java > 1540645 > > Diff: https://reviews.apache.org/r/15417/diff/ > > > Testing > ------- > > Patch used in our application to create a different type of token. > > > Thanks, > > Andreas Kohn > >
