-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15626/
-----------------------------------------------------------
Review request for shindig.
Bugs: SHINDIG-1952
https://issues.apache.org/jira/browse/SHINDIG-1952
Repository: shindig
Description
-------
>From JIRA:
osapi.container.GadgetHolder.dispose should take care of all cleanup. Today it
will remove elements but it does not cleanup any OAHub config.
GadgetHolder.dispose should call
osapi.container.GadgetHolder.removeOaaContainer_ if the holder was created via
osapi.container.GadgetHolder.doOaaIframeHtml_.
If removeOaaContainer_ is not called we can get into situations where
OpenAjax.hub.ManagedHub has a handle to an OpenAjax.hub.IframeContainer which
references DOM elements that no longer exist.
I've noticed this issue most frequently when a gadget is doing
requestNavigateTo calls in Apache Rave. GadgetHolder.doOaaIframeHtml_ will
call GadgetHolder.removeOaaContainer_ with an iframeId for which
OpenAjax.hub.ManagedHub still has an IframeContainer object, but which no
longer exists in the DOM. This causes reference errors down the line in
IframeContainer~finishDisconnect().
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
1541488
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
1541488
Diff: https://reviews.apache.org/r/15626/diff/
Testing
-------
Wrote a new unit test. Existing unit tests pass.
Thanks,
Stanton Sievers
