Hi Ryan, thanks. I don't see any other way for us at the moment, but the patch is easy enough to carry around locally. If I find a nicer way I'll get back to you :)
-- Andreas On Mon, Nov 11, 2013 at 11:48 PM, Ryan Baxter <[email protected]> wrote: > Andreas, I took a quick look at the patch and I don't think we can > accept this patch for inclusion in 2.5.1 because it would break > consumers of Shindig due to the API changes. I see what you are > trying to accomplish and I don't have a problem with the approach > except for the fact that there are changes to the interfaces. > > On Mon, Nov 11, 2013 at 5:20 AM, Andreas Kohn <[email protected]> > wrote: > > Hi, > > > > in OpenSocial (2.5.1) a Person can have multiple 'email' addresses. These > > are simple Strings, and so in Shindig 'emails' is declared as > > "List<ListField>". > > > > In our application we want to extend the emails to include additional > > information such as if/how often an email sent to that address has > bounced. > > > > From what I can see there is currently no "proper" way of doing that > apart > > from patching Person itself. > > > > What we have done now is to patch Shindig to provide an 'Email' type, > which > > is currently implemented as an empty extension of ListField(Impl). In our > > guice modules we then inject our custom Email implementation. > > > > The attached patch shows the changes in Shindig. > > > > I'm not completely happy with that approach, but I also couldn't find > > anything "better" that avoids duplicating a lot of information or code. > > > > Do you have any suggestions on how to implement our use case, or would > you > > consider accepting the patch as an improvement for extensibility? > > > > Regards, > > -- > > Andreas >
