-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15960/
-----------------------------------------------------------
(Updated Dec. 4, 2013, 3:53 p.m.)
Review request for shindig.
Changes
-------
* add a constant for 'messages'
* pull common code out of the loop
* update javadoc for MESSAGE_TABLE to match comment in canonicaldb.json
Bugs: SHINDIG-1960
https://issues.apache.org/jira/browse/SHINDIG-1960
Repository: shindig
Description
-------
Fix #createMessage():
* assign a random message id if it wasn't done from the outside (no checks for
uniqueness are done if one is given)
* properly access the json data
Note: this contains the functional fixes from
https://reviews.apache.org/r/15420/ / SHINDIG-1951 without the method signature
changes.
Diffs (updated)
-----
trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
1547796
trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
1547796
Diff: https://reviews.apache.org/r/15960/diff/
Testing
-------
Unit test exercises both changed parts.
Thanks,
Andreas Kohn
