-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16289/
-----------------------------------------------------------
Review request for shindig.
Bugs: SHINDIG-1935
https://issues.apache.org/jira/browse/SHINDIG-1935
Repository: shindig
Description
-------
A patch for Shindig-1935.
This patch contains two changes . The first change is to increase the maxDepth
of sizeOfPolicy for template library cache, as the template file can be complex
enough to exceed the original 1000 limitation .
Another change is to rewrite the template xml string before parsing. This
reduces the string object number counted by ehcache. The rewrite can be
controlled by a property in shindig.properties. The negative impact is it would
impact the readability of the gadget code in browser.
Diffs
-----
trunk/java/common/conf/shindig.properties 1550619
trunk/java/common/src/main/resources/org/apache/shindig/common/cache/ehcache/ehcacheConfig.xml
1550619
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateLibraryFactory.java
1550619
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java
1550619
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/TemplateLibraryFactoryTest.java
1550619
Diff: https://reviews.apache.org/r/16289/diff/
Testing
-------
Tested with a template with lots of lines.
Without the patch , we will get the warning message as shindig-1935.
With the patch, there is no such warning message. And the gadget can be
rendered successfully.
Thanks,
Yun Zhi Lin
