> On Jan. 9, 2014, 1:08 a.m., Ryan Baxter wrote: > > Rene I guess I am a little confused, how could we ever apply this patch to > > Shindig if it would require additional software to run Shindig with it? > > René Peinl wrote: > Ryan, now I'm a little confused too. I guess you would do it the same way > as you did before with MySQL or any other database server. You would download > the JAR files or compile the code, which is open source. > For your convenience, we have put everything in a package on dropbox. > https://dl.dropboxusercontent.com/u/32445341/WebsocketServer.zip > Just extract it, add the data we referenced in the previous comment and > run the jar file. > > Our Shindig module is an optional one, so if any user decides not to use > it there is no problem. (It will only be compiled when the profile > "websocket-backend" is specified as can be seen in the pom file) > > We forgot to provide some user IDs from our sample dataset so you can > formulate some requests. > The IDs are effectively integers; the range from 0 to 200 should be > filled completely. > > Ryan Baxter wrote: > Rene, I went back and read thought the README in the patch and after > reading this I wondered if you have considered creating a separate upstream > project for this? There is a lot of manual manipulation of the code and then > you have to repackage everything. With an upstream project you don't have to > worry about doing any of this, you ca have your own web app the demonstrated > the graph db implementation. Also I assume that if you were to put this on > github you would avoid the legal issues with neo4j and be able to include the > dependencies. > > René Peinl wrote: > Ryan, thanks for your comments. I can't really believe that you don't > want to include our patch although it would give Shindig a proper database > backend, which it doesn't have currently and we explicitly asked whether you > would like to have it before we started. The last comment from you on 25th of > July 2013 was: "I think Rene can move forward with his proposal". What made > you change your mind? > If it is only a problem of how to compile it with the rest of Shindig, > I'm sure we can work it out together. Maybe Florian's description is not the > best way to do it. I think if you compile our code together with the rest if > Shindig before packaging the WAR file then there would be no need to > repackage. Florian took the old JPA backend and it's deployment as an example > for his own description. > Please reconsider this. > > > Ryan Baxter wrote: > Rene, by no means am I saying we can't deliver the patch I am just trying > to solve the problem of making it as easy as possible to use it. Could we > create another maven project that produces a war containing a web xml with > the correct guice modules? > > René Peinl wrote: > That seems like a good solution to me. We will work on that.
We've updated the patch attached to the issue, so that a war file is built. The default values for the configuration files should fit with the demo database we have provided. For changes in the configuration files you will still need to extract them from the war file and add them after editing. - René ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9773/#review31420 ----------------------------------------------------------- On Jan. 8, 2014, 1:37 p.m., René Peinl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9773/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 1:37 p.m.) > > > Review request for shindig. > > > Bugs: Shindig-1911 > https://issues.apache.org/jira/browse/Shindig-1911 > > > Repository: shindig > > > Description > ------- > > Review for Shindig-1911 > Alternative database backend based on graph database neo4j > Any comments welcome. We are committed to further improve this. > > > Diffs > ----- > > /trunk/java/websocket-backend/LICENSE PRE-CREATION > /trunk/java/websocket-backend/NOTICE PRE-CREATION > /trunk/java/websocket-backend/README PRE-CREATION > /trunk/java/websocket-backend/pom.xml PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/Constants.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GraphAPIModule.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/GuiceModule.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/WebsockConfig.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrgPersonImpl.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ExtOrganizationImpl.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrgPerson.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/IExtOrganization.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ADataTransferObject.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AccountDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/ActivityObjectDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AddressDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/AlbumDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/DTOHelper.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaItemDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MediaLinkDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/OrganizationDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTO.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/GraphListFieldList.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/model/ws/PersonObjectNodeWrapper.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/ExtPersonHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/service/UserHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/servlet/CrawlableServlet.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IExtPersonService.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IFriendService.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/IGraphService.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivitySPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMediaItemSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivitySPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherActivityStreamSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGraphSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherGroupSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherMessageSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/spi/cypher/WsCypherPersonSPI.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/social/websockbackend/util/CollOptsConverter.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ClientWebSocket.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/MultiWebSocketConnector.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/ServerResponseHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/WebSocketConnector.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/BasicQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IErrorFuture.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IMessageCallback.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryCallback.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/IQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MessageFuture.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/MultiConnQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/queries/ResultFuture.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/EQueryType.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/IMessageHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/WebsockQuery.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/BinaryTransferUtil.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/StringTransferUtil.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/TransferUtil.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBinaryTransferUtil.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingBsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingStringTransferUtil.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTSafeJsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/logging/LoggingTransferUtil.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeBsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateBsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeDeflateJsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/safe/TSafeJsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/BsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateBsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/query/encoding/unsafe/DeflateJsonQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/AResultSet.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/EResultType.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/ListResult.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/SingleResult.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/result/TableResult.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/service/Neo4jServiceQueries.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockConstants.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/session/WebsockSession.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/shindig/ShindigNativeQueries.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/BsonConverter.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/EFilterOperation.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ImplUtil.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONList.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JSONMap.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/JsonConverter.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/java/org/apache/shindig/websock/util/ResultSetConverter.java > PRE-CREATION > > /trunk/java/websocket-backend/src/main/resources/websocket-backend.properties > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/MultiWebSocketConnectorTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/TestWebsocketServer.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/WebsocketConnectorTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/BasicQueryHandlerTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/FakeWebsockSession.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MessageFutureTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/MultiConnQueryHandlerTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/NopMessageHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/ResultFutureTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestMessageHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/queries/TestQueryHandler.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BinaryTransferUtilTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/BsonMessageHandlersTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/JsonMessageHandlersTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/StringTransferUtilTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/query/encoding/TransferUtilTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/ListResultTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/SingleResultTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/result/TableResultTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/BsonConverterTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ImplUtilTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONListTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JSONMapTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/JsonConverterTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/de/hofuniversity/iisys/neo4j/websock/util/ResultSetConverterTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/ActivityEntryDTOTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/GroupDTOTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageCollectionDTOTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/MessageDTOTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/model/dto/PersonDTOTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/service/UserHandlerTest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WSNativeMediaItemSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeActivityStreamSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAlbumSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeAppDataSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeFriendSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGraphSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeGroupSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativeMessageSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/spi/WsNativePersonSPITest.java > PRE-CREATION > > /trunk/java/websocket-backend/src/test/java/org/apache/shindig/social/websockbackend/util/CollOptsConverterTest.java > PRE-CREATION > /trunk/pom.xml 1556165 > > Diff: https://reviews.apache.org/r/9773/diff/ > > > Testing > ------- > > > Thanks, > > René Peinl > >
