-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18435/
-----------------------------------------------------------
Review request for shindig.
Bugs: SHINDIG-1968
https://issues.apache.org/jira/browse/SHINDIG-1968
Repository: shindig
Description
-------
Introduce a CollectionOptionsFactory class, and inject & use that instead of
creating CollectionOptions instances explicitly.
See bug for details.
Diffs
-----
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/ActivityHandler.java
1571416
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/ActivityStreamHandler.java
1571416
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AlbumHandler.java
1571416
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/GroupHandler.java
1571416
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MediaItemHandler.java
1571416
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/MessageHandler.java
1571416
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java
1571416
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java
1571416
/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptionsFactory.java
PRE-CREATION
/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/ActivityHandlerTest.java
1571416
/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/ActivityStreamHandlerTest.java
1571416
/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AlbumHandlerTest.java
1571416
/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/MediaItemHandlerTest.java
1571416
/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/MessageHandlerTest.java
1571416
/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java
1571416
Diff: https://reviews.apache.org/r/18435/diff/
Testing
-------
Patch used in production application to inject a different implementation: a
big amount of minimally changed copy/pasted code could be removed, and replaced
with the shindig-provided *Handler/*Service implementations.
Thanks,
Andreas Kohn
