> On 六月 24, 2014, 8:23 p.m., Ryan Baxter wrote:
> > I delivered the change but had to revert it because it is breaking the
> > build, some unit tests are failing. Can you please look into this? Also
> > it would be good to make sure this new code is covered by a unit test.
>
> Jiaqing Guo wrote:
> I have fixed the problem in the test case and add test cases for my
> changeset.
> By the way, I found
> DefaultTemplateProcessorTest#testSafeCrossDocumentCloning case is always
> failed and it break the build process. I confirmed it is not related to my
> changeset.
> Are there anyone know it?
>
> Ryan Baxter wrote:
> I did a build before applying your patch and it passed there was no
> failure. I just applied your patch and did another build and it passed as
> well. Where are you seeing a failure?
What I saw is:
Tests run: 18, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.279 sec
<<< FAILURE!
testSafeCrossDocumentCloning(org.apache.shindig.gadgets.templates.DefaultTemplateProcessorTest)
Time elapsed: 0 sec <<< ERROR!
java.lang.ClassCastException: java.util.Hashtable incompatible with
java.util.WeakHashMap
at
org.apache.shindig.gadgets.templates.DefaultTemplateProcessorTest.testSafeCrossDocumentCloning(DefaultTemplateProcessorTest.java:261)
But I think it is just there is something wrong in my environment, I will try
to resolve it.
It is fine if the build process with my patch is passed in your environment.
- Jiaqing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22363/#review46570
-----------------------------------------------------------
On 十月 18, 2014, 3:16 p.m., Jiaqing Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22363/
> -----------------------------------------------------------
>
> (Updated 十月 18, 2014, 3:16 p.m.)
>
>
> Review request for shindig, Dan Dumont, Ryan Baxter, Rich Thompson, and
> Stanton Sievers.
>
>
> Bugs: SHINDIG-1978
> https://issues.apache.org/jira/browse/SHINDIG-1978
>
>
> Repository: shindig
>
>
> Description
> -------
>
> If gadget spec contains a "ModulePrefs" tag with "title" attribute like below:
> <ModulePrefs title="this is title" description="Hello World Embedded
> Experience gadget" height="400" width="500">
> Then expect the loaded gadget should contain proper "title" element like
> below:
> <html>
> <head>
> <title>this is title</title>
> ......
> But the actual result is the load gadget doesn't contain "title" element.
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java
> 1605175
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java
> 1533559
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java
> 1620491
>
> Diff: https://reviews.apache.org/r/22363/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiaqing Guo
>
>
