Hi Doug, While it may not be on everyone's radar, would it be possible to remove the comments in the following JSON files so that they are valid JSON prior to the release, so that we can use Shindig without requiring a patch? The files are:
./config/gadget-admin.json ./config/oauth2.json ./config/oauth.json ./content/sampledata/canonicaldb.json Also, the ./config/container.js file is being parsed as JSON, so comments would need to be removed from it. We're integrating Shindig into a larger framework and while apparently the parsers being used in Shindig development are lenient (i.e., permit invalid content), the ones that we're using are failing these files. We're using both the json.org parser, which conforms to the EMCA-404 JSON standard, and the Gson parser, which we don't set in lenient mode (for security and data integrity reasons). Thanks very much for your consideration, Ichiro On Thu, Nov 20, 2014 at 5:40 AM, Davies,Douglas <davi...@oclc.org> wrote: > I found an issue with the updated guava version conflicting with our > bonecp version, but I've fixed it in our end. So still a +1 and looking > forward to the release. > > doug > > On Nov 15, 2014, at 10:55 AM, Ryan Baxter <rbaxte...@gmail.com> wrote: > > > +1 from me. > > > > I one other PMC member could check the release than we can publish it. > > > > On Thu, Nov 13, 2014 at 8:53 AM, Stanton Sievers <ssiev...@apache.org> > wrote: > >> +1 > >> > >> Signatures and hashes look good. Smoketest of the sample common > container > >> looks good. > >> > >> On Mon, Nov 10, 2014 at 8:41 PM, Ryan Baxter <rbaxte...@apache.org> > wrote: > >> > >>> Hi, > >>> > >>> We solved 6 issues: > >>> > >>> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SHINDIG%20AND%20fixVersion%20%3D%202.5.2%20AND%20status%20%3D%20Resolved%20ORDER%20BY%20priority%20DESC > >>> > >>> There are still a couple of issues left in JIRA: > >>> > >>> > https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&pid=12310741&status=1 > >>> > >>> Staging repo: > >>> > https://repository.apache.org/content/repositories/orgapacheshindig-1001/ > >>> > >>> Web site: > >>> http://shindig.apache.org/ > >>> > >>> Vote open for 72 hours. > >>> > >>> [ ] +1 > >>> [ ] +0 > >>> [ ] -1 > >>> > > >
