-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28756/
-----------------------------------------------------------
(Updated Dec. 5, 2014, 4 p.m.)
Review request for shindig.
Bugs: SHINDIG-1989
https://issues.apache.org/jira/browse/SHINDIG-1989
Repository: shindig
Description (updated)
-------
In commoncontainer if I set renderDebug as follows
testConfig[osapi.container.ContainerConfig.RENDER_DEBUG] = '0';
and then in container.js it does this
this.renderDebug_ = (typeof param === 'undefined') ?
Boolean(osapi.container.util.getSafeJsonValue(config,
osapi.container.ContainerConfig.RENDER_DEBUG, false)) :
(param === '1');
which sets this.renderDebug_ to TRUE (incorrectly). I think the creation of the
Boolean is only caring that the string has a value and setting to TRUE. I'm
fixing the container/documentation rather than having container.js interpret
both a string and boolean.
Diffs
-----
trunk/content/README 1642996
trunk/content/containers/commoncontainer/assembler.js 1642996
trunk/content/containers/embeddedexperiences/EEContainer.js 1642996
Diff: https://reviews.apache.org/r/28756/diff/
Testing
-------
Thanks,
Doug Davies
