> On Dec. 8, 2014, 6:39 p.m., Doug Davies wrote: > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java, > > line 302 > > <https://reviews.apache.org/r/28755/diff/2/?file=785542#file785542line302> > > > > Hmmm... maybe this should be an OR. If the request says to ignore OR > > if the respoinse says to ignore.
nevermind. it think it's right. - Doug ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28755/#review64254 ----------------------------------------------------------- On Dec. 8, 2014, 6:35 p.m., Doug Davies wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28755/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 6:35 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1984 > https://issues.apache.org/jira/browse/SHINDIG-1984 > > > Repository: shindig > > > Description > ------- > > When doing an OAUTH2 flow the first request to the service that returns the > oauthApprovalUrl probably shouldn’t be cached or set in the staleResponse, > because then it could possibly be used on the response for the ACTUAL request > if it returns a 500. Thus an endless loop of display the approval url and > making the service call. > > > Diffs > ----- > > > trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java > 1642996 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java > 1642996 > > Diff: https://reviews.apache.org/r/28755/diff/ > > > Testing > ------- > > > Thanks, > > Doug Davies > >