----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36642/#review92412 -----------------------------------------------------------
The changes look fine, but I imagine this could break some clients right? - Ryan Baxter On July 21, 2015, 1:46 p.m., Andreas Kohn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36642/ > ----------------------------------------------------------- > > (Updated July 21, 2015, 1:46 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1996 > https://issues.apache.org/jira/browse/SHINDIG-1996 > > > Repository: shindig > > > Description > ------- > > Change the 'expires_in' field in the token response to be in seconds > > > Diffs > ----- > > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2AuthorizationHandler.java > 1692108 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/oauth2/OAuth2TokenHandler.java > 1692108 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/core/oauth/OAuth2AuthCodeFlowTest.java > 1692108 > > Diff: https://reviews.apache.org/r/36642/diff/ > > > Testing > ------- > > * unit tests adjusted to verify the value (previously they just checked for > > 0) > > > Thanks, > > Andreas Kohn > >
