[
https://issues.apache.org/jira/browse/SHIRO-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491307#comment-14491307
]
Les Hazlewood commented on SHIRO-498:
-------------------------------------
Thank you very much for the patch!
It has been applied to the following branches:
trunk
branches/1.x
branches/1.2.x
branches/2.0-api-design-changes
> ThreadLocal should not be created when not necessary
> ----------------------------------------------------
>
> Key: SHIRO-498
> URL: https://issues.apache.org/jira/browse/SHIRO-498
> Project: Shiro
> Issue Type: Improvement
> Affects Versions: 1.2.2
> Reporter: Jochen Kemnade
> Assignee: Kalle Korhonen
> Labels: patch
> Attachments: 0001-don-t-create-ThreadLocals-when-not-needed.patch
>
>
> org.apache.shiro.util.ThreadContext.getValue(Object) and
> org.apache.shiro.util.ThreadContext.remove(Object) initialze the TheadLocal
> unnecessarily via initialValue(). Both methods should return without creating
> the ThreadLocal to avoid potential memory leaks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
