[ 
https://issues.apache.org/jira/browse/SHIRO-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15947433#comment-15947433
 ] 

Marc G. commented on SHIRO-618:
-------------------------------

I'll provide a pull request!

You don't need a *shiro-spring-boot-common* you can move the code from the 
*spring-boot-web-starter* to the *spring-boot-starter* project and add the 
*spring-boot-starter* as a dependency to the *spring-boot-web-starter* project.

The Spring MVC project also adds other starters:
https://github.com/spring-projects/spring-boot/blob/master/spring-boot-starters/spring-boot-starter-web/pom.xml

I've also working on a starter project where I'm adding your shiro web starter.



> Spring Boot Web Starter- Autoconfiguration for Realm and 
> ShiroFilterChainDefinition
> -----------------------------------------------------------------------------------
>
>                 Key: SHIRO-618
>                 URL: https://issues.apache.org/jira/browse/SHIRO-618
>             Project: Shiro
>          Issue Type: Improvement
>            Reporter: Marc G.
>
> After adding the spring-boot-web-starter you got the exception that two beans 
> are missing.
> * Realm
> * ShiroFilterChainDefinition
> Are they not defined on purpose? Both can be provided as a default with 
> @ConditionalOnMissingBean.
> A default TextConfigurationRealm could be configured with properties.
> Providing defaults makes it easier to get startet. 
> I could provide a pull request if desired.
> What do you think?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to