[ 
https://issues.apache.org/jira/browse/SHIRO-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17106139#comment-17106139
 ] 

Andy Seaborne commented on SHIRO-744:
-------------------------------------


Our dependency configuration:

[jena/jena-fuseki2/jena-fuseki-webapp/pom.xml|https://github.com/apache/jena/blob/1e6600536f2b9a968406b7e5273eff601600291a/jena-fuseki2/jena-fuseki-webapp/pom.xml#L65]

which has a  tree of:

{noformat}
. . .
[INFO] +- org.apache.shiro:shiro-core:jar:1.5.1:compile
[INFO] |  +- org.apache.shiro:shiro-lang:jar:1.5.1:compile
[INFO] |  +- org.apache.shiro:shiro-cache:jar:1.5.1:compile
[INFO] |  +- org.apache.shiro:shiro-crypto-hash:jar:1.5.1:compile
[INFO] |  |  \- org.apache.shiro:shiro-crypto-core:jar:1.5.1:compile
[INFO] |  +- org.apache.shiro:shiro-crypto-cipher:jar:1.5.1:compile
[INFO] |  +- org.apache.shiro:shiro-config-core:jar:1.5.1:compile
[INFO] |  +- org.apache.shiro:shiro-config-ogdl:jar:1.5.1:compile
[INFO] |  |  \- commons-beanutils:commons-beanutils:jar:1.9.4:compile
[INFO] |  |     \- commons-collections:commons-collections:jar:3.2.2:compile
[INFO] |  \- org.apache.shiro:shiro-event:jar:1.5.1:compile
[INFO] +- org.apache.shiro:shiro-web:jar:1.5.1:compile
[INFO] |  \- org.owasp.encoder:encoder:jar:1.2.2:compile
. . .
{noformat}

> Overlapping classes cause warnings when shading.
> ------------------------------------------------
>
>                 Key: SHIRO-744
>                 URL: https://issues.apache.org/jira/browse/SHIRO-744
>             Project: Shiro
>          Issue Type: Bug
>            Reporter: Andy Seaborne
>            Assignee: Francois Papon
>            Priority: Major
>             Fix For: 2.0.0
>
>
> Project has dependecny on shiro-core and shiro-web, no other shiro artifacts.
> When shading (maven plugin) the project WARNING's are emitted:
> {noformat}
> [WARNING] shiro-crypto-hash-1.5.1.jar, shiro-core-1.5.1.jar define 24 
> overlapping classes: 
> [WARNING]   - org.apache.shiro.crypto.hash.format.ProvidedHashFormat
> [WARNING]   - org.apache.shiro.crypto.hash.format.HexFormat
> [WARNING]   - org.apache.shiro.crypto.hash.Sha1Hash
> [WARNING]   - org.apache.shiro.crypto.hash.Md2Hash
> [WARNING]   - org.apache.shiro.crypto.hash.ConfigurableHashService
> [WARNING]   - org.apache.shiro.crypto.hash.HashRequest
> [WARNING]   - org.apache.shiro.crypto.hash.format.Shiro1CryptFormat
> [WARNING]   - org.apache.shiro.crypto.hash.format.HashFormat
> [WARNING]   - org.apache.shiro.crypto.hash.Sha256Hash
> [WARNING]   - org.apache.shiro.crypto.hash.format.DefaultHashFormatFactory
> [WARNING]   - 14 more...
> {noformat}
> and a 3 way one:
> {noformat}
> [WARNING] shiro-config-ogdl-1.5.1.jar, shiro-config-core-1.5.1.jar, 
> shiro-core-1.5.1.jar define 5 overlapping classes: 
> [WARNING]   - org.apache.shiro.config.Ini$1
> [WARNING]   - org.apache.shiro.config.Ini$Section
> [WARNING]   - org.apache.shiro.config.ResourceConfigurable
> [WARNING]   - org.apache.shiro.config.Ini
> [WARNING]   - org.apache.shiro.config.ConfigurationException
> {noformat}
> Looking in the jars, indeed both shiro-crypto-hash-1.5.1.jar, 
> shiro-core-1.5.1.jar have the same classes. It is as if shiro artifacts 
> include parts of shiro-core that they use.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to