[
https://issues.apache.org/jira/browse/SHIRO-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128350#comment-17128350
]
Kevin Read commented on SHIRO-781:
----------------------------------
I started working on this and have modularised the basic modules - so nothing
in shiro.support.* yet. I can run the CLI target from maven and also complete a
mvn package, but the unit tests in crypto.hash fail for me.
{code:java}
[INFO] Running org.apache.shiro.crypto.hash.DefaultHashServiceTest
[ERROR] Tests run: 11, Failures: 0, Errors: 9, Skipped: 0, Time elapsed: 0.69 s
<<< FAILURE! - in org.apache.shiro.crypto.hash.DefaultHashServiceTest
[ERROR] testPrivateSaltChangesResult Time elapsed: 0.563 s <<< ERROR!
groovy.lang.MissingMethodException: No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hashPredictable() is
applicable for argument types:
(org.apache.shiro.crypto.hash.DefaultHashService, String) values:
[org.apache.shiro.crypto.hash.DefaultHashService@fade1fc, password]
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testPrivateSaltChangesResult(DefaultHashServiceTest.groovy:145)
[ERROR] testDifferentIterations Time elapsed: 0.007 s <<< ERROR!
groovy.lang.MissingMethodException:
No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hash() is applicable for
argument types: (org.apache.shiro.crypto.hash.DefaultHashService, String)
values: [org.apache.shiro.crypto.hash.DefaultHashService@6ff65192, test]
Possible solutions: wait(), any(), each(groovy.lang.Closure), hashCode(),
grep(), dump()
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testDifferentIterations(DefaultHashServiceTest.groovy:51)
[ERROR] testOnlyRandomSaltHash Time elapsed: 0.005 s <<< ERROR!
groovy.lang.MissingMethodException:
No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hash() is applicable for
argument types: (org.apache.shiro.crypto.hash.DefaultHashService, String)
values: [org.apache.shiro.crypto.hash.DefaultHashService@2dd80673, password]
Possible solutions: wait(), any(), each(groovy.lang.Closure), hashCode(),
grep(), dump()
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testOnlyRandomSaltHash(DefaultHashServiceTest.groovy:96)
[ERROR] testDifferentRandomNumberGenerator Time elapsed: 0.071 s <<< ERROR!
groovy.lang.MissingMethodException:
No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hash() is applicable for
argument types: (org.apache.shiro.crypto.hash.DefaultHashService, String)
values: [org.apache.shiro.crypto.hash.DefaultHashService@7c541c15, test]
Possible solutions: wait(), any(), each(groovy.lang.Closure), hashCode(),
grep(), dump()
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testDifferentRandomNumberGenerator(DefaultHashServiceTest.groovy:65)
[ERROR] testBothSaltsRandomness Time elapsed: 0.004 s <<< ERROR!
groovy.lang.MissingMethodException:
No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hash() is applicable for
argument types: (org.apache.shiro.crypto.hash.DefaultHashService, String)
values: [org.apache.shiro.crypto.hash.DefaultHashService@3542162a, password]
Possible solutions: wait(), any(), each(groovy.lang.Closure), hashCode(),
grep(), dump()
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testBothSaltsRandomness(DefaultHashServiceTest.groovy:108)
[ERROR] testWithRandomlyGeneratedSalt Time elapsed: 0.003 s <<< ERROR!
groovy.lang.MissingMethodException:
No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hash() is applicable for
argument types: (org.apache.shiro.crypto.hash.DefaultHashService, String)
values: [org.apache.shiro.crypto.hash.DefaultHashService@698122b2, password]
Possible solutions: wait(), any(), each(groovy.lang.Closure), hashCode(),
grep(), dump()
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testWithRandomlyGeneratedSalt(DefaultHashServiceTest.groovy:76)
[ERROR] testBothSaltsReturn Time elapsed: 0.004 s <<< ERROR!
groovy.lang.MissingMethodException:
No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hash() is applicable for
argument types: (org.apache.shiro.crypto.hash.DefaultHashService, String)
values: [org.apache.shiro.crypto.hash.DefaultHashService@aa549e5, password]
Possible solutions: wait(), any(), each(groovy.lang.Closure), hashCode(),
grep(), dump()
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testBothSaltsReturn(DefaultHashServiceTest.groovy:121)
[ERROR] testDifferentAlgorithmName Time elapsed: 0.005 s <<< ERROR!
groovy.lang.MissingMethodException:
No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hash() is applicable for
argument types: (org.apache.shiro.crypto.hash.DefaultHashService, String)
values: [org.apache.shiro.crypto.hash.DefaultHashService@36f48b4, test]
Possible solutions: wait(), any(), each(groovy.lang.Closure), hashCode(),
grep(), dump()
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testDifferentAlgorithmName(DefaultHashServiceTest.groovy:44)
[ERROR] testBothSaltsHash Time elapsed: 0.004 s <<< ERROR!
groovy.lang.MissingMethodException:
No signature of method:
org.apache.shiro.crypto.hash.DefaultHashServiceTest.hash() is applicable for
argument types: (org.apache.shiro.crypto.hash.DefaultHashService, String)
values: [org.apache.shiro.crypto.hash.DefaultHashService@1bb564e2, password]
Possible solutions: wait(), any(), each(groovy.lang.Closure), hashCode(),
grep(), dump()
at
org.apache.shiro.crypto.hash/org.apache.shiro.crypto.hash.DefaultHashServiceTest.testBothSaltsHash(DefaultHashServiceTest.groovy:133)
[INFO] Running org.apache.shiro.crypto.hash.format.Base64FormatTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 s
- in org.apache.shiro.crypto.hash.format.Base64FormatTest
[INFO] Running org.apache.shiro.crypto.hash.format.HexFormatTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.005 s
- in org.apache.shiro.crypto.hash.format.HexFormatTest
[INFO] Running org.apache.shiro.crypto.hash.format.ProvidedHashFormatTest
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 s
- in org.apache.shiro.crypto.hash.format.ProvidedHashFormatTest
[INFO] Running org.apache.shiro.crypto.hash.format.DefaultHashFormatFactoryTest
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further
details.
[INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.083 s
- in org.apache.shiro.crypto.hash.format.DefaultHashFormatFactoryTest
[INFO] Running org.apache.shiro.crypto.hash.format.Shiro1CryptFormatTest
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.029 s
- in org.apache.shiro.crypto.hash.format.Shiro1CryptFormatTest
[INFO] Running org.apache.shiro.crypto.hash.HashRequestBuilderTest
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 s -
in org.apache.shiro.crypto.hash.HashRequestBuilderTest
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] DefaultHashServiceTest.testBothSaltsHash:133 » MissingMethod No
signature of m...
[ERROR] DefaultHashServiceTest.testBothSaltsRandomness:108 » MissingMethod No
signatur...
[ERROR] DefaultHashServiceTest.testBothSaltsReturn:121 » MissingMethod No
signature of...
[ERROR] DefaultHashServiceTest.testDifferentAlgorithmName:44 » MissingMethod
No signat...
[ERROR] DefaultHashServiceTest.testDifferentIterations:51 » MissingMethod No
signature...
[ERROR] DefaultHashServiceTest.testDifferentRandomNumberGenerator:65 »
MissingMethod N...
[ERROR] DefaultHashServiceTest.testOnlyRandomSaltHash:96 » MissingMethod No
signature ...
[ERROR] DefaultHashServiceTest.testPrivateSaltChangesResult:145 »
MissingMethod No sig...
[ERROR] DefaultHashServiceTest.testWithRandomlyGeneratedSalt:76 »
MissingMethod No sig...
[INFO]
[ERROR] Tests run: 41, Failures: 0, Errors: 9, Skipped: 0
{code}
I'd be happy for some input. Please feel free to play with the code:
[https://github.com/unverbraucht/shiro/tree/SHIRO-781-JMPS]
> Add JPMS support
> ----------------
>
> Key: SHIRO-781
> URL: https://issues.apache.org/jira/browse/SHIRO-781
> Project: Shiro
> Issue Type: Improvement
> Reporter: Francois Papon
> Priority: Major
> Labels: jpms, modularization, module, modules
> Fix For: 2.0.0
>
>
> Add module-info to support JPMS.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
