fpapon commented on code in PR #192:
URL: https://github.com/apache/shiro-site/pull/192#discussion_r1455181106
##########
pom.xml:
##########
@@ -6,7 +6,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
- <version>24</version>
+ <version>31</version>
</parent>
<groupId>org.apache.shirp</groupId>
Review Comment:
Why do we have "shirp" rather than "shiro" in the `groupId`?
##########
pom.xml:
##########
@@ -6,7 +6,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
- <version>24</version>
+ <version>31</version>
Review Comment:
Is the upgrade of ASF pom parent mandatory for this PR? (I know that is good
to upgrade but may be in another PR for the record and commit diff)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
