nudles commented on issue #624: SINGA-487 Include NCCL and MPICH in conda build
URL: https://github.com/apache/singa/pull/624#issuecomment-598212865
 
 
   > 
   > 
   > Sorry, please let me clarify:
   > 
   >     1. yes, travis is for cpu only, that’s why I created a separate folder 
tool/conda/singa/travis to NOT include the gpu related library cudnn, nccl, and 
mpich. This folder is only used by travis for cpu version build.
   > 
   >     2. I added the nccl and mpich in the meta file of original folder 
tool/conda/singa, which is not for travis and used for gpu version of singa 
conda build
   > 
   >     3. Currently this PR should be adding nccl into singa-gpu. Meanwhile, 
it is also good to separate singa-dist and singa-gpu
   >        Thanks a lot!
   
   1. since travis is for cpu-only, why do you create another folder for it? 
nothing needs to be changed. the scripts for travis building are 
[here](https://github.com/apache/singa/tree/dev/tool/travis)
   2. we only need to add a folder conda/dist like conda/cpu and conda/gpu for 
building singa-dist, and update the scripts in conda/singa/ accordingly.  
meta.yml of conda supports `if` like this 
[line](https://github.com/apache/singa/blob/dev/tool/conda/singa/meta.yaml#L52).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to