nudles commented on issue #691: URL: https://github.com/apache/singa/issues/691#issuecomment-629609089
To be consistent, I think we'd better always call `m.compile()` explicitly? ```python m=MyModel() m.compile([x], use_graph=True) m.load_states(fpath) m=MyONNXModel(onnx_model) m.compile([x], use_graph=True) m=singa.load(fpath) m.compile([x], use_graph=True) ``` Then the `load_states()` only has a single argument, i.e., fpath. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
