chrishkchris commented on a change in pull request #770:
URL: https://github.com/apache/singa/pull/770#discussion_r457850417
##########
File path: src/api/singa.i
##########
@@ -25,10 +25,5 @@
%include "config.i"
%include "core_tensor.i"
%include "core_device.i"
-%include "model_layer.i"
-%include "model_optimizer.i"
Review comment:
But even if I put the `%include "model_optimizer.i"` back, there is
another error
```
======================================================================
ERROR: test_sgd_cuda (test_optimizer.TestOptimizer)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/root/dcsysh/singa/test/python/test_optimizer.py", line 117, in
test_sgd_cuda
sgd = opt.SGD(lr)
File "/root/dcsysh/singa/build/python/singa/optimizer.py", line 222, in
__init__
self.opt = singa.CreateOptimizer('SGD'.encode())
TypeError: in method 'CreateOptimizer', argument 1 of type 'std::string
const &'
```
The c optimizer is very old and deprecated (not used anymore)? Our current
optimizer is in python
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
