[
https://issues.apache.org/jira/browse/SINGA-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730591#comment-14730591
]
ASF subversion and git services commented on SINGA-21:
------------------------------------------------------
Commit 53de92b7fdf7e6eac58fe86663738377bedfbd36 in incubator-singa's branch
refs/heads/master from Wei Wang
[ https://git-wip-us.apache.org/repos/asf?p=incubator-singa.git;h=53de92b ]
SINGA-21 Code review 4
categorize all layers into 5 types: input, loss, output, neuron and
connection layers.
remove all is_xxlayer functions. Worker::TrainOneBatch() and
Worker::TestOneBatch() have to check the layer type using other methods
(e.g., typeinfo from typeid()). A function like type_id() may be added to
return the type ID of a specific layer (which can be overridden by users).
tested with example cnn, mlp, and rbm models.
> Code Review
> -----------
>
> Key: SINGA-21
> URL: https://issues.apache.org/jira/browse/SINGA-21
> Project: Singa
> Issue Type: Task
> Reporter: Sheng Wang
> Assignee: Sheng Wang
>
> Clean the code for first release.
> Code style follows google c++ code
> style(https://google-styleguide.googlecode.com/svn/trunk/cppguide.html).
> Style check tool
> cpplint(http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py)
> is recommanded to help clean the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
