joddiy commented on a change in pull request #528: SINGA 475 - add logical operator: and, or, xor, not & negative, reciprocal URL: https://github.com/apache/incubator-singa/pull/528#discussion_r325107434
########## File path: python/singa/autograd.py ########## @@ -2522,3 +2523,144 @@ def backward(self, dy): def max(a,b): return Max()(a,b)[0] + +class And(Operation): + def __init__(self): + super(And, self).__init__() + + def forward(self, a, b): + m = singa.__div__(a,b) Review comment: This part cannot pass the cpu test case, plz use this. ``` m = singa.__mul__(a, b) cur = singa.PowFloat(singa.Sign(m), 2) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services