Hey Martin, Thanks for taking care of this work and I saw the Threads classes you've been working on. I have a question -- how do these relate to the java.util.concurrent packages -- are those incompatible with OSGI giving us a need to construct our own such classes in SIS, or are the classes you are committing complementary and/or orthogonal to java.util.concurrent?
Thanks! Cheers, Chris On Oct 3, 2012, at 2:44 AM, Martin Desruisseaux wrote: > Hello Chris and all > > Thanks for the feedback on MessageFormat! > > Next topic: we are suppose to be OSGi-ready, but I actually have no > experience in that aspect. From what I have read, we must ensure that all > threads created by a module must be terminated when the bundle stop. > > I committed a Threads class (not part of public API) in > org.apache.sis.internal, which we can use for keeping trace of all threads > created by the library (only one in the "sis-utility" module). I used it in > the past for grouping the library threads under a single ThreadGroup, which > is quite helpful when inspecting the threads in a debugger. In a pure JSEE > environment, we just let the daemon threads die on JVM exit. But in an OSGi > environment, my understanding is that we shall terminate those threads > explicitly. I added an OSGiActivator class for that purpose (implements > BundleActivator, declared in the MANIFEST.MF file). Is there other aspects > that I should be aware of (I know there is also ThreadLocal variables to be > careful with)? > > Thanks, > > Martin > > > > > Le 02/10/12 16:21, Mattmann, Chris A (388J) a écrit : >> +1 for MessageFormat, for the exact reasons you specify below (err on the >> side of >> readability and understandability). > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Senior Computer Scientist NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 171-266B, Mailstop: 171-246 Email: [email protected] WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Adjunct Assistant Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
