Hello Sisinda
Le 29/07/2017 à 05:10, Sisinda Dinusha a écrit :
> I forgot to add those new files. Now they have pushed to the repo.
>
Thanks.
> I was unable to run Instrumented tests (the tests that run in an
> Android environment) using Maven (yet). So far I compiled those tests
> and ran them through Android Studio IDE which is using Gradle. We
> maybe able to run tests direclty using Maven because Android Maven
> plugin have support for Instrumented testing according to the
> documentation.
So the "provided" and "compile" scope of "android-test" and
"com.android.support.test" are temporary, and the scope is expected to
be changed to "test" when the instrumented testing issues will be resolved?
About the recent work related to Java2D, I would suggest to put the
Point2D, Path2D, etc. classes in another package than
"org.apache.sis.geometry". The reason is that "org.apache.sis.geometry"
is intended for ISO 19107 geometries, which are very different than
Java2D geometries. The ISO 19107 geometries are not yet in Apache SIS,
but this is future work we would like to do. Another home for Java2D
classes could be "org.apache.sis.internal.referencing.j2d", together
with existing Java2D-related classes.
Looking at AffineTransform and Curve classes, the source code seems very
similar to code from the JDK. Since JDK code is under GPL license, we
can not create derivative work in Apache projects. Would it be possible
to omit those classes? We do not need to reproduce all Java2D
functionalities in the Android port of SIS. It is okay if we lost Path2D
for example. Regarding AffineTransform, Android has its own Affine
class. What about creating an AffineTransform class as a wrapper around
the Android Affine class? It may also ease integration with other
Android API later.
Martin
