Ok for me. +1
Johann Sorel
On 22/09/2019 13:25, Martin Desruisseaux wrote:
Well spotted! Thanks Alexis for checking. I fixed those copyright
years on the Git repository.
I suppose there is no need to create a 1.0-RC2 for this error. But the
fixes are there if we do a 1.0.1 release in the future.
Martin
Le 21/09/2019 à 12:47, Alexis Manin a écrit :
I've got a few questions :
1. In NOTICE, line 2, copyright extends to 2018. Shouldn't it be
2019 ?
2. In README, line 52, copyright extends to 2015. Shouldn't it be
2019 ?
Otherwise, it looks good to me.
+1