Martin Desruisseaux created SIS-603:
---------------------------------------

             Summary: Make SQLStore abstract for allowing more customization
                 Key: SIS-603
                 URL: https://issues.apache.org/jira/browse/SIS-603
             Project: Spatial Information Systems
          Issue Type: Task
          Components: Storage
    Affects Versions: 1.4
            Reporter: Martin Desruisseaux
            Assignee: Martin Desruisseaux
             Fix For: 1.5


{{SQLStore}} needs to be more extensible for making possible to use it as the 
basis of a Geopackage data store. The most important change is that the array 
of {{ResourceDefinitions}} (which specifies the tables, views or queries to 
view as {{FeatureSet}} resources) cannot be specified at construction time, 
because in a Geopackage file, this array is determined by the 
{{"gpkg_contents"}} table. It is more convenient to read this table _after_ 
{{SQLStore}} construction because it allows reusing an existing connection and 
makes some services such as {{findCRS(srid)}} or {{findSRID(crs)}} available. 
However, this change requires that we make {{SQLStore}} an abstract class, 
because the {{ResourceDefinition}} objects are now specified by an 
{{readResourceDefinitions()}} method that sub-classes must override.

Another change is that the type of resources returned by {{SQLStore}} needs to 
be relaxed from {{FeatureSet}} to {{Resource}}.

Another change is that a low-level access to the database is needed, for 
allowing subclasses such as a Geopackage store to perform their own SQL query. 
This is done by a new class, {{DataAccess}}.

h1. Incompatible changes
Above-described changes contain the above incompatible changes:

* {{SQLStore}} class has been made abstract.
* {{ResourceDefinitions...}} argument in {{SQLStore}} constructor has been 
removed.
* {{SQLStore.components()}} and {{findResource(String)}} now return 
{{Resource}} instead of {{FeatureSet}}.

All the behavior of the old {{SQLStore}} are provided by 
{{SimpleFeatureStore}}. If any of above incompatible changes break an existing 
code, replacing {{SQStore}} by {{SimpleFeatureStore}} should fix the problem in 
mos cases.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to