zone1511 commented on issue #763: Decouple JDBCURL parser logic from URLParser URL: https://github.com/apache/incubator-skywalking/issues/763#issuecomment-359153634 As the parser moved to individual database plugin . The original test case in jdbc common is no longer valid. Should I remove it? And move the case to individual plugin test folder? Sent from my iPhone > On 20 Jan 2018, at 1:36 PM, ?? Wu Sheng <[email protected]> wrote: > > So I just pull request and it will trigger the test or I run junit test locally? but I didnt see any junit test cover spring boot + mysql? > > Normal junit test cases doesn't fit most of java agent tests. That is why @ascrutae contribute his auto test solution with docker(-compose) isolation. If @ascrutae hasn't finished all guides/documents, you can ask him directly for guidances. > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
