wu-sheng commented on a change in pull request #1001: Fix Auhentication token works incorrect URL: https://github.com/apache/incubator-skywalking/pull/1001#discussion_r178225673
########## File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/remote/GRPCChannel.java ########## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.agent.core.remote; + +import io.grpc.Channel; +import io.grpc.ManagedChannel; +import io.grpc.ManagedChannelBuilder; +import io.grpc.NameResolverProvider; +import io.grpc.internal.DnsNameResolverProvider; +import io.grpc.netty.NettyChannelBuilder; +import java.util.LinkedList; +import java.util.List; + +/** + * @author zhangxin + */ +public class GRPCChannel { + /** + * origin channel + */ + private final ManagedChannel originChannel; + private final Channel channelWithInterceptors; + + private GRPCChannel(String host, int port, List<ChannelBuilder> channelBuilders, + List<Interceptor> interceptors, int maxInboundMessageSize, boolean usePlaintext, + NameResolverProvider nameResolverFactory) throws Exception { Review comment: I prefer these three should be in a ChannelBuilder called StandardChannelBuilder - int maxInboundMessageSize - boolean usePlaintext - NameResolverProvider nameResolverFactory ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
