Thanks. Please approve the PR

Wei Zhang & Xin Zhang
I think I should wait for your confirmations too. This is an important
feature, I hope could be rechecked.

Sheng Wu 吴晟
Twitter, wusheng1108


Daming <[email protected]> 于2019年11月20日周三 上午11:00写道:

>
> +1 (with standalone ES7.4.2)
>
> Daming(@dmsolr)
> Apache SkyWalking
>
>
>
> > 在 2019年11月18日,下午9:02,kezhenxu94 <[email protected]> 写道:
> >
> > Thanks @arugal, the exception due to a miss-adapted DAO class, and it
> has been fixed
> > in the pull request
> >
> >
> > Thanks
> >
> >
> >
> >
> >
> >
> >
> >
> > --
> >
> > GitHub @kezhenxu94
> > Apache SkyWalking, Apache Dubbo
> >
> >
> >
> > At 2019-11-18 19:22:45, "Wei Zhang" <[email protected]> wrote:
> >> Hi, everyone
> >>
> >> I started a single node oap using es7 as storage.
> >> Found the following error:
> >>
> >>
> >>
> >> java.lang.NoSuchMethodError:
> org.elasticsearch.search.aggregations.AggregationBuilders.avg(Ljava/lang/String;)Lorg/elasticsearch/search/aggregations/metrics/avg/AvgAggregationBuilder;
> >>       at
> org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.MetricsQueryEsDAO.functionAggregation(MetricsQueryEsDAO.java:92)
> ~[storage-elasticsearch-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.server.storage.plugin.elasticsearch7.query.MetricsQueryEsDAO.getValues(MetricsQueryEsDAO.java:56)
> ~[storage-elasticsearch7-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.server.core.query.MetricQueryService.getValues(MetricQueryService.java:82)
> ~[server-core-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.query.graphql.resolver.MetricQuery.getValues(MetricQuery.java:53)
> ~[query-graphql-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.query.graphql.resolver.MetricQueryMethodAccess.invoke(Unknown
> Source) ~[reflectasm-1.11.7.jar:6.6.0-SNAPSHOT]
> >>
> >> java.lang.NoSuchMethodError:
> org.elasticsearch.search.aggregations.AggregationBuilders.avg(Ljava/lang/String;)Lorg/elasticsearch/search/aggregations/metrics/avg/AvgAggregationBuilder;
> >>       at
> org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.MetricsQueryEsDAO.functionAggregation(MetricsQueryEsDAO.java:92)
> ~[storage-elasticsearch-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.server.storage.plugin.elasticsearch7.query.MetricsQueryEsDAO.getValues(MetricsQueryEsDAO.java:56)
> ~[storage-elasticsearch7-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.server.core.query.MetricQueryService.getValues(MetricQueryService.java:82)
> ~[server-core-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.query.graphql.resolver.MetricQuery.getValues(MetricQuery.java:53)
> ~[query-graphql-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.query.graphql.resolver.MetricQueryMethodAccess.invoke(Unknown
> Source) ~[reflectasm-1.11.7.jar:6.6.0-SNAPSHOT]
> >>
> >> java.lang.NoSuchMethodError:
> org.elasticsearch.search.aggregations.AggregationBuilders.avg(Ljava/lang/String;)Lorg/elasticsearch/search/aggregations/metrics/avg/AvgAggregationBuilder;
> >>       at
> org.apache.skywalking.oap.server.storage.plugin.elasticsearch.query.MetricsQueryEsDAO.functionAggregation(MetricsQueryEsDAO.java:92)
> ~[storage-elasticsearch-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.server.storage.plugin.elasticsearch7.query.MetricsQueryEsDAO.getValues(MetricsQueryEsDAO.java:56)
> ~[storage-elasticsearch7-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.server.core.query.MetricQueryService.getValues(MetricQueryService.java:82)
> ~[server-core-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.query.graphql.resolver.MetricQuery.getValues(MetricQuery.java:53)
> ~[query-graphql-plugin-6.6.0-SNAPSHOT.jar:6.6.0-SNAPSHOT]
> >>       at
> org.apache.skywalking.oap.query.graphql.resolver.MetricQueryMethodAccess.invoke(Unknown
> Source) ~[reflectasm-1.11.7.jar:6.6.0-SNAPSHOT]
> >>
> >>
> >> Github @arugal
> >> Apache SkyWalking
> >>
> >>
> >>
> >>
> >> 2019年11月17日 23:52,Sheng Wu <[email protected]<mailto:
> [email protected]>> 写道:
> >>
> >> Hi,
> >>
> >> SkyWalking with ES7 PR[1] has been submitted by Zhenxu Ke.
> >> It changed the dependency tree, package mode and a lot of codes.
> >>
> >> Although e2e tests passed, I request the whole community to review PR,
> test
> >> and feedback.
> >>
> >> [1] https://github.com/apache/skywalking/pull/3870
> >>
> >> Sheng Wu 吴晟
> >> Twitter, wusheng1108
> >>
>
>
>
>

Reply via email to