wu-sheng edited a comment on pull request #297: URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312
This PR is much better now, I think we left the following things to improve 1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex=10000` means 1.0 at the front page, but now, even no calculation rule is set, the value is still correct. SLA has a similar case. Please cross-check the codes. 1. The linear graph type is not configurable, but SLA has the bar graph, but others are linear. I think we should open an option about this, for `get all values` and `get all values of labels`. 1. `All entities(max 30)` should be an option when `Entity type = service or instance` and metrics query is `get all values`. When clicked, all items in the common selector should be queried and visualized in the current graph. (This is important for @hanahmily 's Prometheus integration, and an important feature as we have removed the comparison view. NOTICE, `max 30` is for avoiding overload when there are 100+ entities. The graph will be a disaster. 1. Separate the service/instance/endpoint dashboard config in the topology pop up page, from the real dashboard. FYI @apache/skywalking-committers, I will add a new GraphQL query to make the backend provide the default configurations for both dashboard and topology pop up page. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
