+1 (binding) I had checked the below items: 1. asc,*sha512 files are correct 2. Install from source code by setup.py 3. Source packages contain LICENSE and NOTICE files. 4. Checks source files license headers
Good luck kezhenxu94@apache <[email protected]> 于2020年12月25日周五 下午12:02写道： > Thanks for pointing out, I just filed a pull request [1] to address that > the build steps targeting the src release. > > [1] https://github.com/apache/skywalking-python/pull/111 > > ————————— > Zhenxu Ke (柯振旭) > GitHub @kezhenxu94 > > > On Dec 25, 2020, at 11:08, Sheng Wu <[email protected]> wrote: > > > > From you the page you referred, it says > >> NOTE that because we use Git submodule, the aforementioned commands > don't > > apply if you download the source codes (.tgz) from our official website. > > > > I think it is a little not accurate, as your precious steps include `make > > install`, which is always required if you use the source codes. > > The key point I want to point out is, only the source tar in the SVN is > the > > real release, we need to keep the compiling source doc clear about how to > > use that. > > > > Sheng Wu 吴晟 > > Twitter, wusheng1108 > > > > > > kezhenxu94@apache <[email protected]> 于2020年12月25日周五 上午11:03写道： > > > >> Hi Sheng, the “compiling passed” means > >> > >> - we have correctly generated .py files from .proto files and; > >> - the source codes reference/import the generated files correctly > without > >> syntax error; > >> > >> As for the link you posted, it’s indeed stale and I’m glad to update it > to > >> > https://github.com/apache/skywalking-python/blob/master/docs/FAQ.md#q-how-to-build-from-sources > >> because we moved this part once > >> > >> > >>> On Dec 25, 2020, at 10:47, Sheng Wu <[email protected]> wrote: > >>> > >>> Hi Ke & Zhenxu > >>> > >>> I want to check what do you mean `compiling passed`? > >>> > >>> Also, I want to check with Zhenxu, compiling doc > >>> > >> > https://github.com/apache/skywalking-python/blob/master/CONTRIBUTING.md#compiling-and-building > >>> is not talking about compiling, is there really compiling for Python > >>> besides runtime. > >>> > >>> Sheng Wu 吴晟 > >>> Twitter, wusheng1108 > >>> > >>> > >>> Ke Zhang <[email protected]> 于2020年12月25日周五 上午10:23写道： > >>> > >>>> +1 > >>>> 1. asc checked > >>>> 2. sha512 checked > >>>> 3. LICENSE and NOTICE exist > >>>> 4. CHANGELOG checked > >>>> 5. commit id and tag checked > >>>> 6. compiling passed > >>>> > >>>> > >>>> kezhenxu94@apache <[email protected]> 于2020年12月24日周四 上午11:27写道： > >>>> > >>>>> Hi The SkyWalking Community: > >>>>> > >>>>> This is a call for vote to release Apache SkyWalking Python version > >>>> 0.5.0. > >>>>> > >>>>> Release notes: > >>>>> > >>>>> * > https://github.com/apache/skywalking-python/blob/v0.5.0/CHANGELOG.md > >>>>> > >>>>> Release Candidate: > >>>>> > >>>>> * https://dist.apache.org/repos/dist/dev/skywalking/python/0.5.0/ > >>>>> > >>>>> * sha512 checksums > >>>>> - > >>>>> > >>>> > >> > 1efc87d97f2d0f5f794c09266be4bf68cefac5423dfc909ba822744e2c09028d926cb514d05a8d1f18dde27a1fc293068055ac8437784e4fbae05d7d8997993b > >>>>> skywalking-python-src-0.5.0.tgz skywalking-python-0.5.0-src.tgz > >>>>> > >>>>> Release Tag : > >>>>> > >>>>> * (Git Tag) v0.5.0 > >>>>> > >>>>> Release CommitID : > >>>>> > >>>>> * > >>>>> > >>>> > >> > https://github.com/apache/skywalking-python/tree/3947a6cee420dcf995f365e6b5391d26b629a688 > >>>>> > >>>>> Keys to verify the Release Candidate : > >>>>> > >>>>> * https://dist.apache.org/repos/dist/release/skywalking/KEYS > >>>>> > >>>>> Guide to build the release from source : > >>>>> > >>>>> * > >>>>> > >>>> > >> > https://github.com/apache/skywalking-python/blob/master/CONTRIBUTING.md#compiling-and-building > >>>>> > >>>>> Voting will start now and will remain open for at least 72 hours, all > >> PMC > >>>>> members are required to give their votes. > >>>>> > >>>>> [ ] +1 Release this package. > >>>>> [ ] +0 No opinion. > >>>>> [ ] -1 Do not release this package because.... > >>>>> > >>>>> Please take part in the vote process. > >>>>> > >>>>> Everyone could vote (though may be no-binding), but make sure to > check > >>>> the > >>>>> list [1]. > >>>>> > >>>>> Thanks. > >>>>> > >>>>> [1] > >>>>> > >>>> > >> > https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-release.md#vote-check > >>>>> > >>>>> ————————— > >>>>> Zhenxu Ke (柯振旭) > >>>>> GitHub @kezhenxu94 > >>>>> > >>>>> > >>>> > >> > >> ————————— > >> Zhenxu Ke (柯振旭) > >> GitHub @kezhenxu94 > >> > >> > >
