+1 binding I've checked - [OK] sha sum is correct. - [OK] tar is correctly signed. - [OK] no unexpected binary files in source tar. - [OK] change logs look good - [OK] LICENSE file and NOTICE file are OK. - [OK] compiling from source succeeded.
One nit, the source tar doesn’t need to include `dist/` as it’s meant to be included in binary distribution. > On Sep 14, 2021, at 13:07, han liu <[email protected]> wrote: > > Hi the SkyWalking Community: > This is a call for vote to release Apache SkyWalking Satellite version > 0.2.0. > > Release notes: > > * https://github.com/apache/skywalking-satellite/blob/v0.2.0/CHANGES.md > > Release Candidate: > > * https://dist.apache.org/repos/dist/dev/skywalking/satellite/0.2.0 > * sha512 checksums > - > 4b1e9eee1adb05819f747ed3d3e29f120521221adf72529f5cd31834ddc2b452be14a914ba2a345074c7f3b9b7cb6cd6a85bb08bd2624321ab5910f0ca8a4300 > apache-skywalking-satellite-0.2.0-bin.tgz > - > 94cbe87b04b9172038f9ffc96fa22d41eecfadf4b07c73230c125bdcdf49d2ef1ce3b33f57288f9cc50c0a9be8a21fd1dd01e7f43eaab50a889272c7418d526f > apache-skywalking-satellite-0.2.0-src.tgz > > Release Tag : > > * (Git Tag) v0.2.0 > > Release Commit Hash : > > * > https://github.com/apache/skywalking-satellite/tree/1ea3ee60eff2c511cc029aadba65fb44b23b438f > > Keys to verify the Release Candidate : > > * https://dist.apache.org/repos/dist/release/skywalking/KEYS > > Guide to build the release from source : > > * > https://github.com/apache/skywalking-satellite/blob/v0.2.0/docs/en/guides/contribution/How-to-release.md > > Voting will start now and will remain open for at least 72 hours, all PMC > members are required to give their votes. > > [ ] +1 Release this package. > [ ] +0 No opinion. > [ ] -1 Do not release this package because.... > > Thanks. > > [1] > https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-release.md#vote-check ————————— Zhenxu Ke (柯振旭) GitHub @kezhenxu94
