> On Sep 22, 2021, at 16:04, Sheng Wu <[email protected]> wrote: > > +1 good to go. > > Just one suggestion, consider this is mostly from testing requirements, how > about using GitHub commitid based images?
It’s not only from testing requirements, we also bundle CLI in our official Docker images for OAP and Java agent. It’s also expected that the users will use this if they prefer, I’d consider this is for general use. So the Docker images pushed to hub.docker.com will be in our release process. There is no doubt that we can also push snapshot Docker images to ghcr.io and use them in our tests, of course. > > Sheng Wu 吴晟 > Twitter, wusheng1108 > > > kezhenxu94@apache <[email protected]> 于2021年9月22日周三 下午3:59写道： > >> Hi all, as we are adopting/ migrating our E2E tests to the new framework >> [1], >> the CLI is becoming more and more complete in terms of features, and we’ve >> been >> also building the CLI into our OAP docker image and Java agent docker >> image, >> now in order to make it more convenient for our users to use and for our >> OAP Docker >> images and agent Docker images to build (and other sub-projects that want >> to build CLI into >> the Docker image), I’d like to propose providing skywalking-cli Docker >> image, >> with this, users can use CLI via docker, and we can copy the binary from >> the released CLI Docker >> image to any eco-system projects where we want to bundle CLI in it. >> >> Here is how we bundle CLI into OAP [2] and Java agent [3], it’s verbose >> and repeated. >> After we have a Docker image for CLI, we can simply do something like: >> >> ```Dockerfile >> COPY --from=apache/skywalking-cli:0.7.0 /bin/swctl /bin/swctl >> ``` >> >> This vote respects the lazy consensus voting policy, so if you have any >> concern please >> let us know ASAP. >> >> [1] https://github.com/apache/skywalking-infra-e2e >> [2] >> https://github.com/apache/skywalking/blob/29104848a6d65008fb7e00c5b4f50c41e67945a0/docker/oap/Dockerfile.oap#L19-L96 >> [3] >> https://github.com/apache/skywalking-java/blob/3e97740036242cf4ee8808b737727a7093b3d31f/Dockerfile#L19-L96 >> >> ————————— >> Zhenxu Ke (柯振旭) >> GitHub @kezhenxu94 >> >> ————————— Zhenxu Ke (柯振旭) GitHub @kezhenxu94
