Sorry didn’t read that compiling doc and thanks for point it out. Then I’m +1 (binding)
- shasum of the tar is OK - tar is signed by [email protected] - LICENSE file and NOTICE file exist - source files have license header where needed - `cargo build` passed. > On Feb 11, 2022, at 21:39, Sheng Wu <[email protected]> wrote: > > Pleaae read the compiling doc, the crate file is the source tar. And rust > doesn't need binary tar, as it is a static compiling language. > > kezhenxu94@apache <[email protected]>于2022年2月11日 周五下午8:38写道： > >> Hi, why do we only release `.crate` binary tars and no source codes? >> We can release that binary if `.crate` is a conveniency in Rust ecosystem >> but source codes are mandatory in Apache release and we’d better provide >> that too in my opinion. >> >>> On Feb 11, 2022, at 20:04, Shimizu Rei <[email protected]> >> wrote: >>> >>> Mail title: [VOTE] Release Apache SkyWalking Rust Agent version 0.1.0 >>> >>> Mail content: >>> Hi All, >>> This is a call for vote to release Apache SkyWalking Rust Agent version >>> 0.1.0 >>> >>> Release Candidate: >>> >>> * https://dist.apache.org/repos/dist/dev/skywalking/rust/0.1.0/ >>> * sha512 checksum >>> >> 15a76798dc92f8ecdb8efc8d775ef969ff6761f7cbd0c5d224ecf019d142d700ddd88e2ce5fa984f709c876012c622c48e389c90f05fa2d2eb3fbc12ba5fda8d >>> skywalking_rust-0.1.0.crate >>> >>> Release Tag : >>> >>> * (Git Tag) v0.1.0 >>> >>> Release CommitID : >>> >>> * https://github.com/apache/skywalking-rust/tree/v0.1.0 >>> * Git submodule >>> * skywalking-data-collect-protocol >>> https://github.com/apache/skywalking-data-collect-protocol/tree/v8.9.1 >>> >>> Keys to verify the Release Candidate : >>> >>> * https://dist.apache.org/repos/dist/release/skywalking/KEYS >>> >>> Guide to build the release from source : >>> >>> * https://github.com/apache/skywalking-rust/tree/master#how-to-compile >>> >>> Voting will start now and will remain open for at least 72 hours, Request >>> all PMC members to give their vote. >>> [ ] +1 Release this package. >>> [ ] +0 No opinion. >>> [ ] -1 Do not release this package because.... >> >> >> >> ————————— >> Zhenxu Ke (柯振旭) >> GitHub @kezhenxu94 >> >> -- > Sheng Wu 吴晟 > > Apache SkyWalking > Apache Incubator > Apache ShardingSphere, ECharts, DolphinScheduler podlings > Zipkin > Twitter, wusheng1108 ————————— Zhenxu Ke (柯振旭) GitHub @kezhenxu94
